New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Introduce `Flex` component #1594

Merged

pavelklibani merged 2 commits into main from feat/ds-1426-flex-react

Sep 3, 2024

Contributor

pavelklibani commented Aug 26, 2024

Description

Additional context

Issue reference

Flex component | React

pavelklibani added the run-visual-tests label

pavelklibani self-assigned this

pavelklibani requested review from literat, curdaj and a team as code owners

August 26, 2024 21:56

github-actions bot added the feature label

netlify bot commented Aug 26, 2024 •

edited

Loading

✅ Deploy Preview for spirit-design-system ready!

Name	Link
🔨 Latest commit	`ad60a64`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system/deploys/66d5cbf68e8e0d00088e6c5e
😎 Deploy Preview	https://deploy-preview-1594--spirit-design-system.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 1 from production) Accessibility: 93 (no change from production) Best Practices: 100 (no change from production) SEO: 82 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Aug 26, 2024 •

edited

Loading

❌ Deploy Preview for spirit-design-system-storybook failed. Why did it fail? →

Name	Link
🔨 Latest commit	`ad60a64`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66d5cbf67829f5000871c7d4

Contributor

github-actions bot commented Aug 26, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10567877681/artifacts/1856790782

Contributor

github-actions bot commented Aug 26, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10567877723/artifacts/1856790826

pavelklibani force-pushed the feat/ds-1426-flex-react branch from b96c4e7 to d7d3da1 Compare

August 26, 2024 22:15

Contributor

github-actions bot commented Aug 26, 2024

Here is the URL of the uploaded artifact:

Contributor

github-actions bot commented Aug 26, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10568184204/artifacts/1856912644

pavelklibani force-pushed the feat/ds-1426-flex-react branch from 47c128c to 9443315 Compare

August 27, 2024 07:52

coveralls commented Aug 27, 2024 •

edited

Loading

coverage: 78.698% (-0.5%) from 79.191%
when pulling ad60a64 on feat/ds-1426-flex-react
into cdc61cf on main.

pavelklibani force-pushed the feat/ds-1426-flex-react branch 2 times, most recently from 6447c88 to 54dbb5a Compare

August 27, 2024 08:36

crishpeen approved these changes

View reviewed changes

packages/web-react/src/components/Flex/Flex.tsx Outdated Show resolved Hide resolved

packages/web-react/src/components/Flex/README.md Outdated Show resolved Hide resolved

packages/web-react/src/components/Flex/README.md Outdated Show resolved Hide resolved

packages/web-react/src/components/Flex/README.md Outdated Show resolved Hide resolved

packages/web-react/src/components/Flex/README.md Outdated Show resolved Hide resolved

packages/web-react/src/components/Flex/README.md Outdated Show resolved Hide resolved

packages/web-react/src/components/Flex/README.md Outdated Show resolved Hide resolved

packages/web-react/src/components/Flex/__tests__/Flex.test.tsx Show resolved Hide resolved

packages/web-react/src/components/Flex/__tests__/useFlexStyleProps.test.ts Show resolved Hide resolved

packages/web-react/src/components/Flex/demo/FlexResponsiveWrapping.tsx Outdated Show resolved Hide resolved

literat reviewed

View reviewed changes

packages/web-react/src/components/Flex/Flex.tsx Show resolved Hide resolved

literat reviewed

View reviewed changes

packages/web-react/src/components/Flex/README.md Outdated Show resolved Hide resolved

literat reviewed

View reviewed changes

packages/web-react/src/components/Flex/__tests__/Flex.test.tsx Outdated Show resolved Hide resolved

literat reviewed

View reviewed changes

packages/web-react/src/components/Flex/__tests__/useFlexStyleProps.test.ts Outdated Show resolved Hide resolved

literat reviewed

View reviewed changes

packages/web-react/src/components/Flex/useFlexStyleProps.ts Outdated Show resolved Hide resolved

literat reviewed

View reviewed changes

packages/web-react/src/utils/generateStylePropsClasses.ts Outdated Show resolved Hide resolved

literat reviewed

View reviewed changes

packages/web-react/src/utils/generateStylePropsClasses.ts Outdated Show resolved Hide resolved

literat reviewed

View reviewed changes

packages/web-react/src/hooks/useAlignmentClass.ts Outdated Show resolved Hide resolved

literat reviewed

View reviewed changes

packages/web-react/src/hooks/useAlignmentClass.ts Outdated Show resolved Hide resolved

Contributor

github-actions bot commented Aug 30, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10631874228/artifacts/1874349348

literat approved these changes

View reviewed changes

pavelklibani force-pushed the feat/ds-1426-flex-react branch from 25a91a4 to 3483352 Compare

August 30, 2024 12:50

pavelklibani force-pushed the feat/ds-1426-flex-react branch 2 times, most recently from a8376d0 to cadf167 Compare

August 30, 2024 12:57

Contributor Author

pavelklibani commented Aug 30, 2024

rebased to main

pavelklibani force-pushed the feat/ds-1426-flex-react branch 2 times, most recently from ccc422e to 634dc0e Compare

August 30, 2024 13:12

Contributor

github-actions bot commented Aug 30, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10633323767/artifacts/1874795026

Contributor

github-actions bot commented Aug 30, 2024

Here is the URL of the uploaded artifact:

1 similar comment

Contributor

github-actions bot commented Aug 30, 2024

Here is the URL of the uploaded artifact:

pavelklibani force-pushed the feat/ds-1426-flex-react branch from af2c712 to 65016c9 Compare

August 30, 2024 14:04

Contributor

github-actions bot commented Aug 30, 2024

Here is the URL of the uploaded artifact:

1 similar comment

Contributor

github-actions bot commented Sep 2, 2024

Here is the URL of the uploaded artifact:

pavelklibani removed the run-visual-tests label

pavelklibani force-pushed the feat/ds-1426-flex-react branch 2 times, most recently from a9b3447 to 79d1ac8 Compare

September 2, 2024 14:09

pavelklibani added 2 commits

September 2, 2024 16:30


          Feat(web-react): Introduce Flex component

1092fbd


          Refactor(web-react): Grid useGridStylesProps use new hooks for genera…

ad60a64

…ting classes

- uses new hook for generate alignment classes

pavelklibani force-pushed the feat/ds-1426-flex-react branch from 3e0413f to ad60a64 Compare

September 2, 2024 14:30

pavelklibani merged commit 8274478 into main

22 checks passed

pavelklibani deleted the feat/ds-1426-flex-react branch

September 3, 2024 08:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature